Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import web page to ipfs #8561

Merged
merged 1 commit into from
Apr 23, 2021
Merged

Import web page to ipfs #8561

merged 1 commit into from
Apr 23, 2021

Conversation

spylogsster
Copy link
Contributor

@spylogsster spylogsster commented Apr 19, 2021

Resolves brave/brave-browser#14770

image

  • Added directory import
  • Saving Web Page using "Save Page As" implementation
  • The download item will be hidden in the download shelf
  • Moved import files to separate import folder

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  • Check various cases when you have ongoing downloads and you do the import for a web page, it should not appear on the shelf with others
  • Check that downloaded pages are not visible in the download history
  • Check that the tab does not crash if downloading is in progress
  • Check imported files have same content as originals
  • Check imported pages open correctly by shareable link

@spylogsster spylogsster requested review from bridiver and a team as code owners April 19, 2021 17:50
@spylogsster spylogsster force-pushed the import-web-page-to-ipfs branch 8 times, most recently from 4f8ed5c to f566bd8 Compare April 20, 2021 13:19
@spylogsster spylogsster force-pushed the import-web-page-to-ipfs branch 3 times, most recently from 48b9ee0 to 41efe97 Compare April 20, 2021 18:54
@spylogsster spylogsster force-pushed the import-web-page-to-ipfs branch from 8d1ae03 to 8245503 Compare April 21, 2021 08:31
@spylogsster spylogsster force-pushed the import-web-page-to-ipfs branch 7 times, most recently from d82bb49 to d3c5452 Compare April 22, 2021 14:46
Copy link
Contributor

@mariospr mariospr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM re: GN changes

(although perhaps it would be better to wait for #8538 first)

@spylogsster spylogsster force-pushed the import-web-page-to-ipfs branch 8 times, most recently from 27f38a1 to d52336a Compare April 23, 2021 11:55
@spylogsster spylogsster force-pushed the import-web-page-to-ipfs branch from d52336a to 7af4275 Compare April 23, 2021 12:36
@spylogsster spylogsster merged commit 2486141 into master Apr 23, 2021
@spylogsster spylogsster deleted the import-web-page-to-ipfs branch April 23, 2021 17:05
@spylogsster spylogsster added this to the 1.25.x - Nightly milestone Apr 23, 2021
kylehickinson pushed a commit that referenced this pull request Jan 4, 2024
…8559)

Fix issue with stats script sending empty image sources
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ability to publish a webpage to IPFS
4 participants